Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge case issue #5

Closed
XhmikosR opened this issue Sep 10, 2019 · 3 comments · Fixed by #9
Closed

Edge case issue #5

XhmikosR opened this issue Sep 10, 2019 · 3 comments · Fixed by #9

Comments

@XhmikosR
Copy link
Collaborator

XhmikosR commented Sep 10, 2019

Initially reported on nodejs/nodejs.org#2422

The current tests cover one similar case, but I think we need a more extended test case. In nodejs.org, we have blog/index.md. Maybe this will trigger the issue here too.

PR which works around the problem: nodejs/nodejs.org#2564

@XhmikosR
Copy link
Collaborator Author

I think for starters, we need to add one more year in tests.

Secondly, we should have a test with blog/index.md instead of blog.md. Maybe this will show the error in tests.

@phillipj
Copy link
Owner

Your suggestions sounds like a good start indeed!

It's been too long since I had anything to do with metalsmith, that I don't really have a gut feeling of what might be wrong here at all.

If we were able to re-produce what's happening for nodejs.org with an unit test or two, that would be extremely valuable, both to fix the bug and going forward ofcourse.

@XhmikosR
Copy link
Collaborator Author

I'll try to find some time in the next days, but perhaps you could add one more year in tests for starters?

We need to change the i < 5 check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants