Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pre-content-sync cordova.js files #190

Open
filmaj opened this issue Apr 21, 2017 · 3 comments
Open

Remove pre-content-sync cordova.js files #190

filmaj opened this issue Apr 21, 2017 · 3 comments
Labels

Comments

@filmaj
Copy link
Collaborator

filmaj commented Apr 21, 2017

The following is no longer needed:

  • res/middleware/cordova
  • res/middleware/hammer
  • lib/middleware/cordova
  • doublecheck lib/middleware/ext/session regarding device version/platform tracking, as that may be purely needed for old cordova stuff.
@filmaj
Copy link
Collaborator Author

filmaj commented Apr 24, 2017

@timkim @surajpindoria can either of you confirm we are safe to remove both:

  1. res/middleware/cordova stuff
  2. res/middleware/hammer stuff

I also love how the one bit that actually does anything with hammer is a test that checks that we don't include hammer 😆

@timkim
Copy link
Contributor

timkim commented Apr 24, 2017

I think you are safe to remove both. I'm trying to remember what we used hammer.js for... I think it was for windows stuff.

@surajpindoria
Copy link
Collaborator

Hammer was the old way of handling the touch events, 3/4 finger taps. I believe it was Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants