You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#7 claimed to add support for Doctrine 4.0, but there are still multiple calls to removed QueryBuilder::execute() method (along with some calls to other removed methods) across the codebase.
Broken automated checks
Cloning the repository and running the test suite results in 11/11 errors which means that the automated checks for the PR incorrectly passed. I took a glance at the workflow file and I suspect this might be due to Composer package caching, which skipped the Install dependencies step and probably used an old version of Doctrine.
Proposed solution
Fixing the source code itself isn't complicated and I might take a shot at it if I have time at some point attempted a fix (see #13), but I think fixing the tests should be the first priority, since that would've immediately detected the broken code. I also find it a bit odd that apparently no tests were run locally at any point.
The text was updated successfully, but these errors were encountered:
Calls to removed methods
#7 claimed to add support for Doctrine 4.0, but there are still multiple calls to removed
QueryBuilder::execute()
method (along with some calls to other removed methods) across the codebase.Broken automated checks
Cloning the repository and running the test suite results in 11/11 errors which means that the automated checks for the PR incorrectly passed. I took a glance at the workflow file and I suspect this might be due to Composer package caching, which skipped the
Install dependencies
step and probably used an old version of Doctrine.Proposed solution
Fixing the source code itself isn't complicated and I
might take a shot at it if I have time at some pointattempted a fix (see #13), but I think fixing the tests should be the first priority, since that would've immediately detected the broken code. I also find it a bit odd that apparently no tests were run locally at any point.The text was updated successfully, but these errors were encountered: