Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work in Doctrine 4.0 and broken automated checks #12

Closed
Cryszon opened this issue Jul 19, 2024 · 1 comment · Fixed by #13
Closed

Doesn't work in Doctrine 4.0 and broken automated checks #12

Cryszon opened this issue Jul 19, 2024 · 1 comment · Fixed by #13
Labels

Comments

@Cryszon
Copy link
Contributor

Cryszon commented Jul 19, 2024

Calls to removed methods

#7 claimed to add support for Doctrine 4.0, but there are still multiple calls to removed QueryBuilder::execute() method (along with some calls to other removed methods) across the codebase.

Broken automated checks

Cloning the repository and running the test suite results in 11/11 errors which means that the automated checks for the PR incorrectly passed. I took a glance at the workflow file and I suspect this might be due to Composer package caching, which skipped the Install dependencies step and probably used an old version of Doctrine.

Proposed solution

Fixing the source code itself isn't complicated and I might take a shot at it if I have time at some point attempted a fix (see #13), but I think fixing the tests should be the first priority, since that would've immediately detected the broken code. I also find it a bit odd that apparently no tests were run locally at any point.

@leeqvip
Copy link
Member

leeqvip commented Jul 22, 2024

🎉 This issue has been resolved in version 2.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants