Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception interfaces should extend Throwable #40

Closed
tux-rampage opened this issue Sep 28, 2021 · 2 comments · Fixed by #32
Closed

Exception interfaces should extend Throwable #40

tux-rampage opened this issue Sep 28, 2021 · 2 comments · Fixed by #32

Comments

@tux-rampage
Copy link

When running Static-Analysis like Psalm, they will report an invalid catch statement:

InvalidCatch: Class/interface Psr\Container\NotFoundExceptionInterface cannot be caught

This happens because the Interfaces do not extend Throwable. This is correct since classes that do not implement Throwable cannot be used with throw: https://3v4l.org/NNDeW
@ChristophWurst
Copy link

See #33 for some context. This was fixed, then reverted again.

@Jean85
Copy link
Member

Jean85 commented Nov 5, 2021

Fixed again in 1.1.2 and 2.0.2

@Jean85 Jean85 closed this as completed Nov 5, 2021
@Jean85 Jean85 linked a pull request Nov 5, 2021 that will close this issue
Bump minimum supported PHP version to 7.4 on v2 releases #32
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump minimum supported PHP version to 7.4 on v2 releases weierophinney/container
3 participants
@tux-rampage @ChristophWurst @Jean85