Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is "Deleted Transactions" supported? #152

Open
JBtje opened this issue Jul 11, 2019 · 3 comments
Open

Is "Deleted Transactions" supported? #152

JBtje opened this issue Jul 11, 2019 · 3 comments

Comments

@JBtje
Copy link

JBtje commented Jul 11, 2019

A quick search did not reveal that the Deleted Transactions API endpoint is implemented, but just to be sure: is it?

https://c3.twinfield.com/webservices/documentation/#/ApiReference/Transactions/DeletedTransactions

If not, I might give it a try to make a PR for it.

@iranl
Copy link
Contributor

iranl commented Jul 11, 2019

It is not implemented right now and also not included in #142

@JBtje
Copy link
Author

JBtje commented Jul 18, 2019

Well... I gave it a try, but in both the current master and your extend-all branch, I wasn't able to figure out the used structure.
iranl/twinfield@extend-all...JBtje:master

Could you provide a bit of background on the structure you're using, and what i'm still missing?

@iranl
Copy link
Contributor

iranl commented Jul 21, 2019

DeletedTransactions is using a unique SOAP endpoint (/webservices/DeletedTransactionsService.svc?wsdl), that is not implemented right now. Only finder.asmx and processxml.asmx are implemented.

So you would need to create a Services\DeletedTransactionsService class that connects to that endpoint and write a function that creates a SoapCall that it understands.

I would use FinderService and the ListAll function as a base instead of ProcessXML and get function, as you are doing right now. Finder is easier to understand and functionality is more closely related to what you are trying to accomplish with requesting deleted transactions.

I can't help you any further than that. Twinfield's API documentation in general and specifically for DeletedTransactions is pretty horrible, which is one of the reasons I chose not to put my time into implementing this endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants