Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpseclib_mcrypt_module_open CFB mapping missing from 1.0 branch #19

Closed
omniError opened this issue Jul 27, 2018 · 2 comments
Closed

phpseclib_mcrypt_module_open CFB mapping missing from 1.0 branch #19

omniError opened this issue Jul 27, 2018 · 2 comments

Comments

@omniError
Copy link

A mapping needed to support CFB mode in mcrypt_module_open is on master but not 1.0. Compare:

master: https://github.com/phpseclib/mcrypt_compat/blob/master/lib/mcrypt.php#L271
1.0 branch: https://github.com/phpseclib/mcrypt_compat/blob/1.0/lib/mcrypt.php#L271

@omniError
Copy link
Author

Reading this more, it looks like master is wrong, it should be passing the ints from the Base class and not strings. So 1.0 needs a line added to include

'cfb' => Base::MODE_CFB8,

@terrafrost
Copy link
Member

Good catch! I've fixed it in 1.0 and made a new release.

The master branch doesn't use phpseclib-2.0 - it uses phpseclib-master. phpseclib-master uses strings - not ints. So there's nothing to fix in the master branch as the newly added unit test demonstrates.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants