Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletter switching to mass mail services. #142

Open
unckleg opened this issue Aug 27, 2017 · 2 comments
Open

Newsletter switching to mass mail services. #142

unckleg opened this issue Aug 27, 2017 · 2 comments

Comments

@unckleg
Copy link
Contributor

unckleg commented Aug 27, 2017

Consider switching to some mass mail service (mailchimp, mailgun) and subscribing through service API's.
Or implementing reCAPTCHA (similar protection system) because DB 'll be filled with spam subscriptions if not already (bots are madness :) ).

@tasmaniski
Copy link
Member

Basically this is a good idea. At the moment, we don't have any problems with the current implementation, although that's what you are saying is correct.

When or if we decide to change it, that would be through a completely separate package, e.g. MailchimpNewsletter.

I could recommend something similar to you :)
if you want to contribute "Contact Us" package. We don't have it.

Contact us should be completely separated package with one more DB table.

Contact us package should hold:

  • Web page with route eg. /contact-us
  • POST request to web page eg. /contact-us-post
  • Admin pages (CRUD)
  • Service layer: ContactUsService, ContactUsEntity, ContactUsMapper, Filters etc.
  • Migration for new db table eg. "contact_us" (migration should be in data/phinx/)
  • The bonus is: reCAPTCHA and Mailchimp (or similar)

Instalation of new package in the existing system:

  • Register new package in config/config.php
  • Run migration to create new table
  • Add link to Admin menu (changes in admin's layout)
  • Add link through admin in the menu with URI "/contact-us"

Please check "Page" for the details and inspiration.

If you would like to continue with this contribution,
feel free to continue the discussion on this thread.

@unckleg
Copy link
Contributor Author

unckleg commented Aug 28, 2017

When or if we decide to change it, that would be through a completely separate package, e.g. MailchimpNewsletter.

Then I think it would be better to develop some MailServiceFactory logic for resolving our Collection MailService packages and it would be easier for developer to plug-in his package into CMS.
But we can talk about it later.

I'm interested in developing ContactUs package so expect new PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants