Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add firebase-query.html to the my-app.html #1

Closed
wants to merge 1 commit into from
Closed

Add firebase-query.html to the my-app.html #1

wants to merge 1 commit into from

Conversation

abdonrd
Copy link

@abdonrd abdonrd commented Feb 3, 2017

(I know that it is not a correct solution)

I'm not sure why, but adding the firebase-query.html to the my-app.html, now the websocket works.

Before:
screen shot 2017-02-03 at 18 48 48

After:
screen shot 2017-02-03 at 18 48 31

Updated:

I see the issue starts in the ^v0.10.1. In the v0.10.0 works well.
FirebaseExtended/polymerfire@v0.10.0...v0.10.1

Updated 2:

I think this PR introduces the issue: FirebaseExtended/polymerfire#131

@phrohdoh
Copy link
Owner

phrohdoh commented Feb 3, 2017

Thank you for this!

Indeed this isn't correct but it does yield the results I am after.

Would you happen to know if this is a bug in polymerfire or is this working as intended but is undocumented?

screen shot 2017-02-03 at 12 55 30 pm

@abdonrd
Copy link
Author

abdonrd commented Feb 3, 2017

Your welcome! :)

I guess this is a mistake.
Maybe @cdata or @mbleigh can clarify.

@cdata
Copy link

cdata commented Feb 3, 2017

It smells like a bug in polymerfire. Specificly, it smells like a race condition ;P

@abdonrd
Copy link
Author

abdonrd commented Feb 4, 2017

I see the issue starts in the ^v0.10.1. In the v0.10.0 works well.

FirebaseExtended/polymerfire@v0.10.0...v0.10.1

@abdonrd
Copy link
Author

abdonrd commented Feb 4, 2017

I think this PR introduces the issue: FirebaseExtended/polymerfire#131

@abdonrd
Copy link
Author

abdonrd commented Feb 6, 2017

@phrohdoh can you create an issue in the firebase/polymerfire repo?

@abdonrd
Copy link
Author

abdonrd commented Feb 11, 2017

Friendly ping to @phrohdoh. :)

@phrohdoh
Copy link
Owner

Hi there, sure! Sorry I have been extremely busy lately.

@phrohdoh
Copy link
Owner

@abdonrd I'd say this is a well-covered issue:

It appears that, as I suspected, the polymerfire team has known about this for a while without taking any concrete steps to resolve it.

@abdonrd
Copy link
Author

abdonrd commented Feb 11, 2017

@phrohdoh I think it is a different issue, because the FirebaseExtended/polymerfire#131 was merged in 21 Oct 2016 and the issues are before.

@phrohdoh
Copy link
Owner

FirebaseExtended/polymerfire#74 is the race condition that @cdata mentioned.

@abdonrd
Copy link
Author

abdonrd commented Feb 11, 2017

@phrohdoh this issue says:

Tested with v0.9.2 and v0.9.4.

And if we use the v0.10.0, the websocket works well. #1 (comment)

@phrohdoh
Copy link
Owner

It works well if you do something to mask the race condition.

No matter, FirebaseExtended/polymerfire#179.

@abdonrd
Copy link
Author

abdonrd commented May 5, 2017

More info: FirebaseExtended/polymerfire@3b751d0

@abdonrd abdonrd closed this May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants