Don't force eager load for Rails 5 #480
Conversation
|
Hi @tap87 Thanks for the PR! I will give it some testing this week. Have you tested with/without a daemon |
| @@ -66,8 +66,10 @@ def load_rails | |||
| else | |||
| # Painful contortions, see 1791 for discussion | |||
| require File.expand_path('config/application.rb') | |||
| ::Rails::Application.initializer 'shoryuken.eager_load' do | |||
| ::Rails.application.config.eager_load = true | |||
| if ::Rails::VERSION::MAJOR == 4 | |||
There was a problem hiding this comment.
@tap87 for keeping compatibility, I'm wondering if instead of checking for Rails 4, we should check for Rails greater than or equals to 5, so all the previous versions, would continue to work in the same they are now, given the issue seems to be only with Rails 5 and greater.
BTW I'm using shoryuken with Rails 5.0.2 and it's working fine.
There was a problem hiding this comment.
Yes, we could take that approach. I tried to follow sidekiq here since that is were the existing code was adapted from. https://github.com/mperham/sidekiq/blob/master/lib/sidekiq/cli.rb#L261
|
I have tested it both with and without the daemon option, and it works fine |
|
Hi @tap87 Sorry, I've been very busy lately, but I added this to my list to check this week. If everything works well, I will merge and release this week. |
|
@tap87 3.2.3 is out with your fix 🎉 Great job, thanks 🍻 |
|
Thanks @phstc |
Addresses #467