Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+Q closes application and stops rendering #189

Closed
phw opened this issue Oct 9, 2017 · 4 comments
Closed

Ctrl+Q closes application and stops rendering #189

phw opened this issue Oct 9, 2017 · 4 comments
Labels
Milestone

Comments

@phw
Copy link
Owner

phw commented Oct 9, 2017

Normally when just closing the Peek window while Peek is rendering, it will continue in the background.

Pressing Ctrl+q however closes the application directly, circumventing the current implementation on the window close event.

@phw phw added the bug label Oct 9, 2017
@phw phw added this to the 1.2.0 milestone Oct 12, 2017
@gort818
Copy link
Contributor

gort818 commented Oct 28, 2017

@phw What if we overwite crtl q to behave as the window close event?

@phw
Copy link
Owner Author

phw commented Oct 28, 2017

It's not just Ctrl-Q, it's also "Quit" in App menu or everything else that closes the application directly(as opposed to closing the window). That means the application close event needs to be interrupted and everything handled there. Might need some refactoring, but haven't looked into it yet.

@phw phw closed this as completed in 14515ba Nov 6, 2017
@phw
Copy link
Owner Author

phw commented Nov 6, 2017

This was easier than I had originally thought :)

@gort818
Copy link
Contributor

gort818 commented Nov 6, 2017

Yeah pretty cool, very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants