-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Peek Window is really thin, making it very hard to resize #199
Comments
Is this the default Ubuntu theme? Which version of Ubuntu is this on? Maybe I have to tweak the styling for this particular theme a bit. |
Changed to defualt theme. Gnome. https://i.imgur.com/PmEZR1r.png This is how it looks like with. Still way too thin but at least it's not transparent anymore. |
Actually it is so thin by purpose, but with the Adwaita theme or Arc (which I use) it is not a big deal, since the area to grab for resizing is larger then just the thin border (you can grab slightly outside the border). I have to test, maybe you could even click slightly inside the border, but this is prevented by the click through of Peek. If so I might make the click-through area 2 or 3 pixel smaller to allow for easier resizing. |
Okay. Thank you for your time. |
Hello! I just installed Peek and encountered the same issue on KDE (Plasma 5.5.5). Besides that, Peek seems really nice! Thank you. Please tell me if I can help you or if you need more details about the issue. |
I will take a look. What GTK theme is this then? |
I am not famliar with desktop themes so I am not sure I use a GTK theme since I run KDE. The KDE theme is Breeze (I suppose it corresponds to this project), this is one of the official (pre-installed) themes as far as I know. Does this answer your question? |
I can confirm this in ubuntu 16.04 with gnome desktop. Basically impossible to resize, but double-clicking the title bar does maximize it. |
Now I also tried the Breeze theme. It maybe looks thinner, but behaves exactly the same. Just to make this clear: In the screenshots above I have easily an area of 10-14 pixels around the edge where I can drag. Isn't that the case for you? Also I can make the visible border around the inner recording area thicker, but that has no influence on the area that is available for resizing. Peek just provides as much space for resizing as every other window I tried to open. |
@davidv171 The only screenshot here that looks of is https://i.imgur.com/GoITz3b.png from your original report. This is also Ambiance, right? What desktop environment is it? |
@phw yes it was ambiance. |
Since I cant edit on mobile its gnome(think I mentioned that somewhere) |
Can I use peek to record peek itself? (Probably not) |
Hello @phw, Thank you for considering the issue.
No, not for me. It seems that:
This is not the case on KDE : the issue I described does not apply to windows of other applications such as Firefox, Konsole, KeePassXC… |
Just an update: In order to reproduce this I tried installing KDE Plasma in my Ubuntu 16.04 VM. Unfortunately Plasma is completely unusable and broken there (most windows are undecorated and full of graphical glitches) and I can't really test with this. Maybe I should install a newer Kubuntu instead or run on real hardware via live CD. |
@phw If you want a decent dedicated linux laptop, the Dell XPS 13 with ubuntu 16.04 preinstalled is pretty good. Something like $1500 cheaper than a Mac too. |
I cloned the repo and tried to tweak some properties in the Then I made a bit of research on the subject and found nothing. It was difficult since I do not know anything about GTK or desktop application UI in general, so maybe I did not search with proper keywords. In the end I found a workaround using the KDE settings: I configured a KWin keyboard shortcut to resize the current window. I still can not grab the window's edges to resize it, but I can trigger a resize using a custom keyboard shortcut. |
I made a screen capture of Peek (using Peek 😄 ) to demonstrate the following statement:
|
I installed KDE Neon in a VM to test this, and yes, I can easily reproduce it. Unfortunately this seems to be an issue with KWin having issues with GTK3 client side decorations (CSD). For some reason the drop shadow is not rendered (which in case of CSD windows GTK3 would need to do). I don't know whether this is a defect in GTK3 or KWin. I could also reproduce the very same annoying issue with GNOME Todo and GNOME calculator. There are two workarounds:
Next step is trying to figure out if I can do anything in the theming to make it work a bit better on KWin with Breeze. After all the default GTK3 theme Adwaita seems to have a workaround for it. |
Related discussion and bug: https://bugzilla.gnome.org/show_bug.cgi?id=729721 The status quo is that GTK does not draw the shadow, as it causes issues with KWin. Not sure exactly what the issues are, but presumably it has to do with size calculations, as the shadows are outside the window and should not be taken by the WM as the outer border of the entire window. |
Oh no, I thought it was either the workaround or the fix. Sorry. |
Not sure we understand each other: The fix alone should be enough. The workarounds should not be applied in this case. I don't know what happens if you apply the workarounds, but it could very well interfere with the fix.. |
So we understood each other until you last question, which I misinterpreted. No, I did not changed the settings as in your workaround. |
Would it be possible to draw the transparent overlay which shows the window size up until recording starts? That way we could easily resize with a Alt (or Meta) + Right mouse drag. Then the fix doesn't depend on a specific theme/desktop environment. |
I have exactly the same problem, using Antergos and latest KDE on Breeze Theme.
|
Back at this again. @gandalf3 I like your suggestion, so I have it a quick and dirty try. In the branch https://github.com/phw/peek/tree/easier-window-resizing-on-kde the click-through behavior is disabled while not recording. And then you can easily resize as you said using the mouse (Alt + right click). Currently it is a bit confusing, because the overlay is not shown, so the area is completely transparent. But I will likely clean this up and show the overlay all the time. Apart from this I am still puzzled why the theme changes are not applied in some cases. For me Peek works very much like any native KDE application regarding the resizing behavior. For me the resizing area at the edges in anooyingly small in all apps, this seems to be a general issue with the Breeze theme. |
@phw Excellent, that's so much better! This way it's easier to use on more unusual WMs as well; I'm currently running bspwm which doesn't do edge-resizing at all, making some version of AltRMB rather indispensable. That said, even when I was using KDE I pretty much never used the edges to resize, preferring SuperRMB. |
I just tested on plasma 5.15 the newest release and breeze theme finally works! They fixed a lot of gtk theme problems in the latest release. |
@phw I think we can close this, seems to work fine now. |
Still thin and impossible to resize for me, Peek 1.4.1 on bspwm |
I'm here because it's thin and impossible for me to resize on my KDE Plasma desktop; I think it's because I've set window borders to none (they're thinner than in @atar-axis's image above, literally exactly one pixel wide). Other windows have a resize area that expands around the window a few pixels, but Peek doesn't seem to (perhaps because it's Gtk?) Thanks for writing/maintaining this awesome utility, other than the lack of resizing my first experience was great! |
It's an old issue, but I tried this workaround and it works great in Plasma (5.16.5). Setting the border size to "no borders" works fine if you uncheck "add handle to resize windows with no border" in Breeze's theme settings. |
This is still a problem for me even after trying to apply that work-around. I found that holding the alt key and doing a right-click-drag was the easiest way to resize the window.
|
I'm using Awesome on Arch Linux and also am having trouble resizing. If changing the border size is too difficult I would also be happy with a way directly enter the size of the capture window. |
@clofresh have you tried this branch? #199 (comment) Perhaps a way to snap to the geometry of existing windows (even as simple as providing a way to specify the window geometry via command line) would be an acceptable workaround? |
If your on KDE hold have the peek window in the foreground (selected) hold down ALT and use the right mouse button to click and drag corners to resize. This works well for me. EDIT: even then if you dont time your click shortly after pressing ALT it can be difficult to grab the corners or borders. |
I can't understand why this is related to the theme being used. There should be a border with same thickness on every theme. This should be done by own code, not by depending on the theme or the desktop environment. |
@ponchofiesta Because basically Plasma did not fully support GTK windows with client decorations, and for those the border is part of the application. That also means themes affect the border size. But Plasma 5.18 actually fixes this, fully supporting GTK windows with client decoration, including drop shadow and bigger area around the window to grab for resizing. With this it now actually looks and works like on e.g. GNOME. I am going to close this issue as everything else that can be done here is just dirty workarounds and hacks. |
Just wanted to post that I am on latest KDE (Ubuntu 18.04.4 and plasma-desktop standard breeze-dark theme) and still have trouble grabbing the bottom left and right corners to resize the peek windows. However if you right click on the title bar of the peek aplication you can choose the resize option, it works around the issue. I found this helpful. |
@phw Don't depend on the window border. Make your own border. I'm not sure how that could be done in GTK. In .NET on Windows I would add some dummy controls of 3px width/height around and add handlers to adjust the cursor on mouse over and resize the window on click+move. Yes, it's still kind of dirty but it should work everywhere. Maybe you could add a parent GtkGrid (3x3) and move the current content to the center cell. Than place those dummy controls around. But I'm not sure if it is possible to set fixed width/height on those controls. But something like this might fix it. |
@ponchofiesta Sorry, I'm not interested in reimplementing parts of Gtk and implement custom window handling just because Plasma does not handle this properly. Especially not since they now fixed it. |
OK, I will continue to use Peek from Snap for now till Kubuntu 20.04.1 is out which hopefully comes with latest Plasma wich fixes it. Please don't remove it :-) |
In KDE/Plasma, one may tweak a specific window's config. Here's an example (French UI):
|
I'm not sure fi this is a good question for Github, but I've noticed the Window is very very thin, making it a pain in the ass to try to resize, the thingie is also completely transparent.
https://i.imgur.com/GoITz3b.png
How do I fix this? This wasnt the issue when I installed Peek on my last Ubuntu install.
The text was updated successfully, but these errors were encountered: