Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show elapsed time during recording #214

Closed
phw opened this issue Nov 6, 2017 · 11 comments
Closed

Show elapsed time during recording #214

phw opened this issue Nov 6, 2017 · 11 comments
Labels
enhancement good first issue help wanted
Milestone
1.2.0

Comments

@phw
Copy link
Owner

phw commented Nov 6, 2017

No description provided.

@phw phw added the enhancement label Nov 6, 2017
This was referenced Nov 6, 2017
Closed
Merged
@gort818
Copy link
Contributor

gort818 commented Nov 11, 2017 •
edited
Loading

I might do some testing with this over the weekend.

@gort818
Copy link
Contributor

gort818 commented Nov 12, 2017

Got a working example! Still got some work to do to make it look nicer, but the functionality is there.
peek 2017-11-11 23-39

@gort818
Copy link
Contributor

gort818 commented Nov 12, 2017 •
edited
Loading

peek 2017-11-12 11-37
Here is a another one with the buttons left aligned .

@gort818
Copy link
Contributor

gort818 commented Nov 12, 2017

peek 2017-11-12 13-16
screenshot from 2017-11-12 13-18-47

@phw
Copy link
Owner Author

phw commented Nov 14, 2017

That last view already looks quite nice. What about centering the recording time between buttons and window controls?

@gort818
Copy link
Contributor

gort818 commented Nov 14, 2017

Ok cool I will do some tests later and let's see how it looks.

@gort818
Copy link
Contributor

gort818 commented Nov 15, 2017

@phw I am having a hard time centering the recording time label widget any idea how to go about this?

@phw
Copy link
Owner Author

phw commented Nov 16, 2017

Not sure actually, I consider myself a GTK beginner still :) But I could take a look, do you have the code up somewhere?

@gort818
Copy link
Contributor

gort818 commented Nov 16, 2017

I'll set up a branch later when I get home.

@gort818
Copy link
Contributor

gort818 commented Nov 17, 2017

Ok take a look!

https://github.com/gort818/peek/tree/update_time

@gort818
Copy link
Contributor

gort818 commented Nov 17, 2017

#227

@phw phw added this to the 1.2.0 milestone Nov 17, 2017
@phw phw closed this as completed Nov 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
2 participants
@phw @gort818