-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'auto' option for populate_phys_input chtrig parameter #257
Comments
Is this related to #204 ? |
This seems to be half way between #204 and the reason we have |
I wasn't aware of |
What do you think if instead: a. we create an alias list with "trig", "trigger", "TRIGGER", [...] Reasoning: During data acquisition it's not granted that you are calling your channels "trig". If you don't have it in your channel names, rasing an error will make phy2bids not able to do its job. However, we can help a bit the user. |
Absolutely. This would be perfect! So there's still an 'auto' option, but it's far more robust than what I originally planned, right? Plus a new check even when the trigger channel is provided. |
I think this is a good thing to implement, however we are gonna have to wait for #273. Since it will affect the |
🚀 Issue was released in |
Users may not know which channel is the trigger channel, so it would help them to be able to auto-detect the trigger channel and, in the absence of useable information, raise an error with the names of the available channels.
Context / Motivation
For any user who doesn't know/remember what their trigger channel is, they have to load the data to a
BlueprintInput
with some random number set as the trigger channel, check the channel names, and then re-load the data with the correct trigger channel index. This should streamline the process in those cases. Plus, it would simplify the standard loading procedure in that there would only be one required argument to the function.Possible Implementation
The text was updated successfully, but these errors were encountered: