Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read hdf5 files generated by bioread #458

Open
oesteban opened this issue Oct 5, 2023 · 1 comment
Open

Read hdf5 files generated by bioread #458

oesteban opened this issue Oct 5, 2023 · 1 comment
Labels
Enhancement New feature or request Hacktoberfest Issue/PR for hacktoberfest. Completing this issue/PR might not grant the all-contributor recognition

Comments

@oesteban
Copy link

oesteban commented Oct 5, 2023

The ability to read hdf5 would permit a better alternative to txt files, which is the easiest way of running phys2bids when you need to operate over the channels.

Detailed Description

Context / Motivation

Using hdf5 as interface would allow faster implementation of new formats.

Possible Implementation

Investing in sniffing the input file and trying to assign the best reader (a la nibabel) would be great.

@oesteban oesteban added the Enhancement New feature or request label Oct 5, 2023
@smoia
Copy link
Member

smoia commented Oct 6, 2023

We use bioread (this bioread) to read in biopac files already, I don't necessarily get the necessity of making an hdf5 interface specifically for it, but let's see what is the best course of action here.

I do like the idea of sniffing files. How does nibabel implement the procedure? Just a list of try statements? Or checkign some property/bytes of the file?

@smoia smoia added the Hacktoberfest Issue/PR for hacktoberfest. Completing this issue/PR might not grant the all-contributor recognition label Oct 6, 2023
@rgbayrak rgbayrak moved this to To Do in phys2bids Jan 18, 2024
@smoia smoia added this to Physiopy Apr 18, 2024
@smoia smoia moved this to PR needs review in Physiopy Apr 18, 2024
@smoia smoia moved this from PR needs review to Priority to-dos in Physiopy Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Hacktoberfest Issue/PR for hacktoberfest. Completing this issue/PR might not grant the all-contributor recognition
Projects
Status: Priority to-dos
Status: To Do
Development

No branches or pull requests

2 participants