Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mobile number field to core table #1580

Open
voltan opened this issue Feb 3, 2018 · 2 comments
Open

Move mobile number field to core table #1580

voltan opened this issue Feb 3, 2018 · 2 comments

Comments

@voltan
Copy link
Member

voltan commented Feb 3, 2018

At this moment we use mobile number as extra field on user module. we can move it to core user account table active login by mobile number too , I think extra filed for valid mobile is required. what is your idea?

@Marc-pi
Copy link
Member

Marc-pi commented Feb 3, 2018

well, i've checked, all fields are set in user/config/user.php by default (you can overwritte through (/usr/custom/module/user/config)
so there is already a field in DB : see user_field table
in that list, there is the phone and mobile phone number

you want to move solely this field to core_user_account ??
we will have issues, because user fields are used everywhere and in order module too.

login with mobile number : with SMS validation (as 2nd factor check) ??
with no SMS 2nd factor check, i doubt it is usefull (a lot of code impact, no enduser strong advantage)
What is your need ? why adding this field ? email or username is not suffiscient (FB/Google do not offer mobile login, except for 2 factor authentification)

@voltan
Copy link
Member Author

voltan commented Feb 4, 2018

Yes, at this moment this field exist , than we just move it to core_user_account, it will not make any problems on any other modules ( like order ) because on all modules get full user information ( both of core and user module fields ) and after change is still will work

Move mobile number to core, just help use to build user login by mobile ( at this moment I keep mobile number on username )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants