Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSBuild configuration should map Language too #236

Closed
Duranom opened this issue Dec 15, 2015 · 5 comments
Closed

MSBuild configuration should map Language too #236

Duranom opened this issue Dec 15, 2015 · 5 comments
Assignees

Comments

@Duranom
Copy link

Duranom commented Dec 15, 2015

Unlike powershell and commandline it is not possible to set the Language for the MSBuild runner.
Setting Pickels_Language is not mapped.

@dirkrombauts
Copy link
Member

Thanks for the catch!

Would it be at all possible for you to contribute a fix?

@dirkrombauts
Copy link
Member

I'm starting on this now.

@dirkrombauts dirkrombauts self-assigned this Dec 17, 2015
@dirkrombauts
Copy link
Member

@Duranom could you please double-check? The property is called Language. Did you read Pickles_Language in our documentation? If so, could you point me to the page so I can correct it? Thanks!

@dirkrombauts
Copy link
Member

@Duranom I think I understand your request now - I got it backwards.

My current understanding is that you expect to be able to set a property Pickles_Language for the MSBuild runner, and that this property sets the language of the feature files.

Could you please confirm that I understood you correctly?

As I wrote earlier, you can set the language using the Language property, but I am the first to admit that that is not consistent with the other properties (as seen at http://docs.picklesdoc.com/en/latest/MSBuildTask/).

If I understood you correctly now, I am willing to add the Pickles_Language property for the sake of consistency.

@dirkrombauts dirkrombauts changed the title MSBuild configuration Language not mapped/available MSBuild configuration should map Language too Dec 30, 2015
@dirkrombauts
Copy link
Member

Released with v2.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants