Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicates after updating groups? #7

Open
pianiemela opened this issue Dec 30, 2019 · 7 comments
Open

Duplicates after updating groups? #7

pianiemela opened this issue Dec 30, 2019 · 7 comments

Comments

@pianiemela
Copy link

The peer-reviews are given for team mates within one group. Group members were updated by uploading a new csv with all course members. Before update, each member was listed once, after update all the group members had duplicates.

Repository owner deleted a comment from pietariheinovincit Dec 30, 2019
@piehei
Copy link
Owner

piehei commented Dec 30, 2019

The peer-reviews are given for team mates within one group. Group members were updated by uploading a new csv with all course members. Before update, each member was listed once, after update all the group members had duplicates.

Thanks for the report!

When you say "after update all the group members had duplicates", what do you specifically mean by these duplicates? Where are the duplicates located?

Are the duplicates shown in the dropdown menu where a student is supposed to give feedback to other members in his/her own group?

@piehei
Copy link
Owner

piehei commented Dec 30, 2019

Can you specify what sort of an update did the newly uploaded CSV include? What changed?

Eg.

  1. someone's email address inside a group changed (amount of students in the group equal before/after)
  2. someone was added to a group

@pianiemela
Copy link
Author

A three-person-group: one person left, another was added. The addition was done with the custom-style csv: groupNmb, email1,email2,email3 - all members in the csv.

@piehei
Copy link
Owner

piehei commented Dec 30, 2019

A three-person-group: one person left, another was added. The addition was done with the custom-style csv: groupNmb, email1,email2,email3 - all members in the csv.

Thanks! What about the duplicates (see my other, earlier message)?

@pianiemela
Copy link
Author

Are the duplicates shown in the dropdown menu where a student is supposed to give feedback to other members in his/her own group?

Yes, there. I made a group of course personnel, we all were duplicates after update. Eliisa's guess was that doubles are due to two ids: Plussa-specific and TUNI-account ids. However, I tested before the update and saw a list of unique values. This changed after the update, thus, id-explanation seems invalid.

@piehei
Copy link
Owner

piehei commented Dec 30, 2019

@pianiemela , in this kind of peer-review exercises there's also a "dummy" submission exercise which is supposed to have one dummy submission for each student. This dummy exercise is supposed to be kept hidden from the students since they cannot return anything into it. The dummy exercise exists only to make the submission exercise / review exercise semantics match across different types of exercises (always 1:1 mapping of a submission exercise to a review exercise).

If you go to this review exercise's dummy submission exercise (left column on the course front page) and look at the submissions in that exercise, do you see duplicate entries? If you see duplicate entries, are they made by the same user account?

@pianiemela
Copy link
Author

Hmm.. interestingly.. only our group (course personnel group) has duplicates there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants