Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider setting termination handlers #406

Closed
msimberg opened this issue Aug 25, 2022 · 1 comment · Fixed by #458
Closed

Reconsider setting termination handlers #406

msimberg opened this issue Aug 25, 2022 · 1 comment · Fixed by #458
Assignees
Labels
effort: 2 A few hours of work. priority: medium This should be done sooner or later. type: cleanup type: feature type: refactoring
Milestone

Comments

@msimberg
Copy link
Contributor

Setting the termination handlers does have value because we can print e.g. stacktraces which are not printed by default on segfaults, pika thread-specific information etc.

On the other hand, when pika is embedded in an application behind multiple other libraries, combined with other runtimes etc. who is to say that pika's termination handler is the termination handler to install?

Some in-between solutions would be to allow users to disable/enable pika's termination handler explicitly (with config options or explicit function calls).

@msimberg
Copy link
Contributor Author

msimberg commented Sep 8, 2022

Possibly make this optional, off by default?

@msimberg msimberg added this to the 0.9.0 milestone Sep 8, 2022
@msimberg msimberg self-assigned this Sep 19, 2022
@bors bors bot closed this as completed in e2c7d5e Sep 19, 2022
Repository owner moved this from Backlog to Done in pika planning board Sep 19, 2022
@msimberg msimberg moved this from Done to Archive in pika planning board Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 2 A few hours of work. priority: medium This should be done sooner or later. type: cleanup type: feature type: refactoring
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant