Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize any_sender to unique_any_sender conversion #556

Closed
msimberg opened this issue Jan 10, 2023 · 0 comments · Fixed by #844
Closed

Optimize any_sender to unique_any_sender conversion #556

msimberg opened this issue Jan 10, 2023 · 0 comments · Fixed by #844
Assignees
@msimberg
Labels
category: senders/receivers P2300 effort: 3 A few days of work. priority: high This is essential functionality or a serious bug. Not addressing this blocks progress. type: feature type: refactoring
Milestone
0.21.0

Comments

@msimberg
Copy link
Contributor

Currently the conversion works because a unique_any_sender can be constructed from any r-value connectable sender, which any_sender is. However, the conversion could be optimized to simply move the internal buffer from the any_sender to the unique_any_sender and potentially avoid an allocation.
@msimberg msimberg added priority: high This is essential functionality or a serious bug. Not addressing this blocks progress. and removed priority: medium This should be done sooner or later. labels Jun 14, 2023
@msimberg msimberg self-assigned this Aug 21, 2023
@msimberg msimberg added this to the 0.19.0 milestone Aug 22, 2023
@msimberg msimberg moved this from Backlog to Todo in pika planning board Sep 8, 2023
@msimberg msimberg moved this from Todo to In Progress in pika planning board Sep 29, 2023
@msimberg msimberg modified the milestones: 0.19.0, 0.20.0 Sep 29, 2023
@msimberg msimberg modified the milestones: 0.20.0, 0.21.0 Oct 24, 2023
@msimberg msimberg mentioned this issue Nov 3, 2023
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in pika planning board Nov 6, 2023
@aurianer aurianer moved this from Done to Archive in pika planning board Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msimberg msimberg

Labels
category: senders/receivers P2300 effort: 3 A few days of work. priority: high This is essential functionality or a serious bug. Not addressing this blocks progress. type: feature type: refactoring
Projects
pika planning board
Status: Archive
Milestone
0.21.0
Development

Successfully merging a pull request may close this issue.

Reuse any_sender storage when moving to a unique_any_sender msimberg/pika
1 participant
@msimberg