Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #255 -- on_delete will be a required arg for ForeignKey/OneToOneField in Django 2.0. #288

Merged
merged 4 commits into from
Dec 21, 2016
Merged

Fixed #255 -- on_delete will be a required arg for ForeignKey/OneToOneField in Django 2.0. #288

merged 4 commits into from
Dec 21, 2016

Conversation

felixxm
Copy link
Contributor

@felixxm felixxm commented Oct 27, 2016 •
edited
Loading

Added default behavior.

@coveralls
Copy link

coveralls commented Oct 27, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling e1abb51 on felixxm:issue-255 into aaa4516 on pinax:master.

@felixxm felixxm changed the title Fixed #255 -- on_delete will be a required arg for ForeignKey in Django 2.0. Fixed #255 -- on_delete will be a required arg for ForeignKey/OneToOneField in Django 2.0. Nov 19, 2016
@coveralls
Copy link

coveralls commented Nov 19, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 3f53365 on felixxm:issue-255 into aaa4516 on pinax:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3f53365 on felixxm:issue-255 into aaa4516 on pinax:master.

@felixxm
Copy link
Contributor Author

felixxm commented Nov 19, 2016

Django master build failure is not related with this PR.

@felixxm
Copy link
Contributor Author

felixxm commented Nov 29, 2016

I fixed tests on Django master in this PR.

paltman
paltman approved these changes Dec 13, 2016
View reviewed changes
Copy link
Contributor

@paltman paltman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic. Thanks!

@coveralls
Copy link

coveralls commented Dec 13, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling a9ee502 on felixxm:issue-255 into d12c367 on pinax:master.

@coveralls
Copy link

coveralls commented Dec 21, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 94b93fd on felixxm:issue-255 into 6615388 on pinax:master.

@coveralls
Copy link

coveralls commented Dec 21, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 94b93fd on felixxm:issue-255 into 6615388 on pinax:master.

@paltman paltman merged commit ec14b69 into pinax:master Dec 21, 2016
@felixxm felixxm deleted the issue-255 branch December 22, 2016 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paltman paltman paltman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixxm @coveralls @paltman