[RFC] admin: prefetch related fields #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
changed the title
blueyed
force-pushed
the
admin-prefetch
branch
from
1ed4168 to
1972feb
Compare
|
I'm a 👍 on this. Can you please use double-quotes is all that I ask, please? |
Sure. At least you do not have two-space indendation.. ;) I have some stashed tests to test the number of queries in existing tests - will update. |
blueyed
force-pushed
the
admin-prefetch
branch
from
25f77aa to
a567f03
Compare
|
Tests have been added - but there might be a better way. |
blueyed
changed the title
blueyed
force-pushed
the
admin-prefetch
branch
from
a567f03 to
353d300
Compare
blueyed
force-pushed
the
admin-prefetch
branch
from
2e0e23b to
96aae71
Compare
blueyed
force-pushed
the
admin-prefetch
branch
from
96aae71 to
30f7dcb
Compare
Codecov Report
@@ Coverage Diff @@
## master #366 +/- ##
=========================================
+ Coverage 99.39% 99.4% +<.01%
=========================================
Files 34 34
Lines 1662 1676 +14
Branches 135 138 +3
=========================================
+ Hits 1652 1666 +14
Misses 5 5
Partials 5 5
Continue to review full report at Codecov.
|
|
Would like some feedback on the tests. |
paltman
approved these changes
Oct 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only does it for the customer's changelist view now, but it meant
to be generic enough for other admins.
You can easily see the number of queries going down when using django-debug-toolbar or something similar.
TODO: