CustomerUpdatedWebhook: use provided customer object from the event #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paltman
requested changes
Sep 21, 2017
pinax/stripe/webhooks.py
Outdated
| customers.sync_customer(self.event.customer) | ||
| cu = None | ||
| try: | ||
| cu = self.event.message['data']['object'] |
There was a problem hiding this comment.
Sure. Anything apart from that?
Shouldn't there be a test (change)?
There was a problem hiding this comment.
Also: maybe we could have pylint or something similar to report this?
There was a problem hiding this comment.
Let machines work for us.. #372
blueyed
force-pushed
the
CustomerUpdatedWebhook-use-data-object
branch
from
f649448 to
04f9f9a
Compare
blueyed
added a commit
to blueyed/pinax-stripe
that referenced
this pull request
Sep 22, 2017
|
Updated branch, so please squash-merge. |
blueyed
force-pushed
the
CustomerUpdatedWebhook-use-data-object
branch
2 times, most recently
from
33878a9 to
18403a9
Compare
|
@paltman |
blueyed
force-pushed
the
CustomerUpdatedWebhook-use-data-object
branch
from
18403a9 to
efa780d
Compare
Codecov Report
@@ Coverage Diff @@
## master #371 +/- ##
==========================================
+ Coverage 99.84% 99.84% +<.01%
==========================================
Files 31 31
Lines 1297 1302 +5
Branches 98 98
==========================================
+ Hits 1295 1300 +5
Partials 2 2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It saves a network roundtrip, and might even be necessary if events are supposed to be processed in order.
TODO: