dmctl fail to operate-source when flavor is not specified and GTID is set

[lichunzhu]

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. What did you do? If possible, provide a recipe for reproducing the error.

cat source.yaml

source-id: "test"

enable-gtid: true
enable-relay: true
relay-binlog-gtid: "8fed3d32-1e6e-11eb-9e0f-0242ac110003:1-2933"
from:
  host: "127.0.0.1"
  user: "root"
  password: ""
  port: 3306
purge:
  remain-space: 15

./dmctl operator-source create source.yaml

2. What did you expect to see?
   Add source successfully.

3. What did you see instead?

[code=11009:class=dm-worker:scope=internal:level=high], Message: relay-binlog-gtid 8fed3d32-1e6e-11eb-9e0f-0242ac110003:1-2933: parse GTID 8fed3d32-1e6e-11eb-9e0f-0242ac110003:1-2933, RawCause: invalid flavor 

4. Versions of the cluster

   • DM version (run dmctl -V or dm-worker -V or dm-master -V):
     1fc1f5fcd7b25d0bfd05589a053ccfe1c4f59422

[lichunzhu]

The root cause is because that

dm/dm/master/server.go

Line 980 in 1fc1f5f

if err := cfg.ParseYaml(content); err != nil {

is before

dm/dm/master/server.go

Line 990 in 1fc1f5f

if err = cfg.Adjust(ctx, fromDB.DB); err != nil {

When we didn't specify flavor dm will not adjust it, dm will fail at

dm/dm/config/source_config.go

Line 183 in 1fc1f5f

_, err = gtid.ParserGTID(c.Flavor, c.RelayBinlogGTID)

[lance6716]

Anyway we could try parse gtid in every flavor if user didn't specified it