Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

UCP: reset some metrics of load unit when resuming #459

Closed
csuzhangxc opened this issue Jan 16, 2020 · 10 comments · Fixed by #558
Closed

UCP: reset some metrics of load unit when resuming #459

csuzhangxc opened this issue Jan 16, 2020 · 10 comments · Fixed by #558
Labels
challenge-program-2 difficulty/easy type/bug This issue is a bug report

Comments

@csuzhangxc
Copy link
Member

csuzhangxc commented Jan 16, 2020 •
edited
Loading

Description

Is your feature request related to a problem? Please describe:

some metrics, like data file size in load dump files may display wrong after resume task because not reset in prepareDataFiles.

Describe the feature you'd like:

we need to reset them when resuming the task, like:

  • calling metricVec.DeleteLabelValues
  • or use another metric type rather than CounterVec.

Score

200

Mentor(s)

Contact the mentors: #tidb-challenge-program channel in TiDB Community Slack Workspace

Recommended Skills

  • Golang
  • Experience with DM
  • Experience with Prometheus

Learning Materials
@csuzhangxc csuzhangxc added the type/bug This issue is a bug report label Jan 16, 2020
@csuzhangxc csuzhangxc changed the title Some metrics were not reset on resume UCP: reset some metrics of load unit when resuming Mar 2, 2020
@sre-bot
Copy link

sre-bot commented Mar 10, 2020

@Kuri-su Please sign up before pick a challenge.
You can signing up by file a issue here https://github.com/tidb-challenge-program/register

@sre-bot
Copy link

sre-bot commented Mar 10, 2020

@Kuri-su pick up issue success

@sre-bot
Copy link

sre-bot commented Mar 10, 2020

@Kuri-su give up issue success

@sre-bot
Copy link

sre-bot commented Mar 17, 2020

@Kuri-su pick up issue success

@sre-bot
Copy link

sre-bot commented Mar 17, 2020

@Kuri-su you have already picked up this issue.

1 similar comment
@sre-bot
Copy link

sre-bot commented Mar 17, 2020

@Kuri-su you have already picked up this issue.

@sre-bot
Copy link

sre-bot commented Mar 17, 2020

@Kuri-su give up issue success

@sre-bot
Copy link

sre-bot commented Mar 17, 2020

@Kuri-su pick up issue success

@Kuri-su
Copy link
Contributor

Kuri-su commented Mar 17, 2020

/pick-up-challenge

@sre-bot
Copy link

sre-bot commented Mar 17, 2020

@Kuri-su you have already picked up this issue.

@Kuri-su Kuri-su mentioned this issue Mar 19, 2020
Merged
@sre-bot sre-bot mentioned this issue Mar 23, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
challenge-program-2 difficulty/easy type/bug This issue is a bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: reset some metrics when loader resume Kur-Public/dm
3 participants
@csuzhangxc @Kuri-su @sre-bot