This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
Proposal: Binlog replication(syncer) unit support plugin #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WangXiangUSTC
added
status/PTAL
Codecov Report
@@ Coverage Diff @@
## master #596 +/- ##
================================================
- Coverage 58.5644% 57.6947% -0.8698%
================================================
Files 204 203 -1
Lines 21344 20579 -765
================================================
- Hits 12500 11873 -627
+ Misses 7671 7557 -114
+ Partials 1173 1149 -24 |
|
/run-all-tests |
csuzhangxc
added
status/LGT1
lichunzhu
reviewed
May 9, 2020
docs/RFCS/20200412_syncer_plugin.md
Outdated
|
|
||
| `HandleDMLJobResult` handle the result of [handleRowsEvent](https://github.com/pingcap/dm/blob/9023c789964fde0f5134e0c49435db557e21fdf7/syncer/syncer.go#L1274) and then do something. | ||
|
|
||
| NOTE: We use `runFatalChan` to report errors between goroutines for executing ddl and dml, and the `err` of `handleQueryEvent` and `handleRowsEvent` don't contain the real error messag. Need to refine it. |
Co-authored-by: Chunzhu Li <lichunzhu@stu.xjtu.edu.cn>
lichunzhu
added
status/LGT2
lichunzhu
previously approved these changes
May 11, 2020
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add a proposal for supporting plugin in binlog replication(syncer) unit