Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

“Placement Rules 使用文档”有歧义,有矛盾 #8049

Closed
alex-quan-001 opened this issue Dec 22, 2021 · 2 comments · Fixed by #8050
Closed

“Placement Rules 使用文档”有歧义,有矛盾 #8049

alex-quan-001 opened this issue Dec 22, 2021 · 2 comments · Fixed by #8050
Labels
area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. type/bugfix This PR fixes a bug.

Comments

@alex-quan-001
Copy link

File: /release-5.3/configure-placement-rules.md

原文1:在配合使用 TiFlash 场景下,Placement Rules 功能进行过大量测试,可以在生产环境中使用。但是,单独开启 Placement Rules 则尚未经过大量测试,因此,不建议在生产环境中单独开启该功能。

原文2:Placement Rules 特性在 TiDB v5.0 及以上的版本中默认开启。如需关闭 Placement Rules 特性,请参考关闭 Placement Rules。

#1, 有歧义, 是指开启 Placement Rules 就能在生产使用 TiFlash,那TiDB 呢?和后半句是冲突的。
#2, 默认是开启的,第一句的后半句又说不建议单独开启,是矛盾的。

@TomShawn TomShawn added area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. type/bugfix This PR fixes a bug. labels Dec 23, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Dec 23, 2021

@alex-quan-001 谢谢反馈~
@rleungx @disksing 能请看下上面提到的两处表述冲突,并建议一种无歧义不矛盾的表述吗?谢谢~

@TomShawn TomShawn linked a pull request Dec 23, 2021 that will close this issue
13 tasks
@TomShawn
Copy link
Contributor

TomShawn commented Dec 23, 2021

@alex-quan-001@disksing 确认,原文 1 在 Placement Rules GA 后就不再适用,删除即可。已在 #8050 中去掉。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants