Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

dumpling should fail when provided positional parameters to CLI #225

Closed
glkappe opened this issue Dec 29, 2020 · 1 comment · Fixed by #228
Closed

dumpling should fail when provided positional parameters to CLI #225

glkappe opened this issue Dec 29, 2020 · 1 comment · Fixed by #228
Labels
good first issue help wanted priority/P2 Medium priority issue severity/minor This issue is a minor bug

Comments

@glkappe
Copy link

glkappe commented Dec 29, 2020

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do? If possible, provide a recipe for reproducing the error.
    https://asktug.com/t/topic/67342
    image

And no detailed execution statements are output in debug mode
debug_test.log

  1. What did you expect to see?
    All exported data

  2. What did you see instead?
    Report an error

  3. Versions of the cluster

    • Dumpling version (run dumpling -V):

      (paste Dumpling version here)
      
    • Source database version (execute SELECT version(); in a MySQL client):

      (paste source database version here)
      
    • Other interesting information (system version, hardware config, etc):

  4. Operation logs

    • Please upload dumpling.log for Dumpling if possible
    • Other interesting logs
  5. Configuration of the cluster and the task

    • running command for Dumpling if possible
@kennytm kennytm changed the title dumpling is not detailed enough to check the where keyword dumpling should fail when provided positional parameters to CLI Dec 29, 2020
@kennytm
Copy link
Collaborator

kennytm commented Dec 29, 2020

What to do: Basically throw an error in main.go if pflag.NArg() is not 0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue help wanted priority/P2 Medium priority issue severity/minor This issue is a minor bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants