-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schedule: let merge not easy to timeout #1495
Conversation
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
CI failed. Should cherry pick to 2.1? |
/rebuild |
Do we need a test? |
PTAL, replace the test and check operator timeout |
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1495 +/- ##
=========================================
Coverage ? 67.28%
=========================================
Files ? 158
Lines ? 15459
Branches ? 0
=========================================
Hits ? 10401
Misses ? 4107
Partials ? 951
Continue to review full report at Codecov.
|
/rebuild |
1 similar comment
/rebuild |
* fix merge easy to timeout Signed-off-by: Connor1996 <zbk602423539@gmail.com> * add test Signed-off-by: Connor1996 <zbk602423539@gmail.com> * change time Signed-off-by: Connor1996 <zbk602423539@gmail.com>
* fix merge easy to timeout Signed-off-by: Connor1996 <zbk602423539@gmail.com>
What problem does this PR solve?
merge operator may timeout easily cause the merge operator timeout span is calculated as LeaderOperatorWaitTime.
What is changed and how it works?
For merge schedule, there will be two operators created. One for the source region (op1), the other for the target region (op2). And cause source region will be destroyed and there will be no heartbeat of it anymore, so op1 will never be finished, instead, it will be cleaned up in the PD background thread. So the op2 is the operator to detect when the merge process finished. But op2 has no steps like
AddPeer
,RemovePeer
, so its timeout is always regarded asLeaderOperatorWaitTime
.This PR makes op2 have the same operator kinds as op1.
Check List