Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schedule: fix a thread-safe bug and improve code (#1719) #1734

Merged
merged 15 commits into from
Sep 11, 2019
Merged

schedule: fix a thread-safe bug and improve code (#1719) #1734

merged 15 commits into from
Sep 11, 2019

Conversation

Luffbee
Copy link
Contributor

@Luffbee Luffbee commented Sep 6, 2019

What problem does this PR solve?

cherry-pick #1719

@Luffbee Luffbee requested review from nolouch and rleungx and removed request for nolouch September 7, 2019 04:09
@nolouch
Copy link
Contributor

nolouch commented Sep 9, 2019

/run-all-tests tidb=release-3.0 tikv=release-3.0 tidb-test=release-3.0

nolouch
nolouch approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nolouch nolouch added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 9, 2019
rleungx
rleungx approved these changes Sep 9, 2019
View reviewed changes
server/schedule/operator_controller.go Outdated Show resolved Hide resolved
server/schedule/operator_controller.go Outdated Show resolved Hide resolved
rleungx
rleungx requested changes Sep 9, 2019
View reviewed changes
Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After thinking about it, I think we don't need to update these two metrics. Because the people who upgrade PD to the next version maybe not upgrade tidb-ansible.

@Luffbee
Copy link
Contributor Author

Luffbee commented Sep 10, 2019

After thinking about it, I think we don't need to update these two metrics. Because the people who upgrade PD to the next version maybe not upgrade tidb-ansible.

Changed them back.

@nolouch nolouch added needs-cherry-pick-release-3.1 The PR needs to cherry pick to release-3.1 branch. status/can-merge Indicates a PR has been approved by a committer. labels Sep 11, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 11, 2019

Your auto merge job has been accepted, waiting for 1748

@sre-bot
Copy link
Contributor

sre-bot commented Sep 11, 2019

/run-all-tests

@sre-bot sre-bot merged commit e07854f into tikv:release-3.0 Sep 11, 2019
@sre-bot sre-bot mentioned this pull request Sep 11, 2019
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Sep 11, 2019

cherry pick to release-3.1 in PR #1751

nolouch pushed a commit that referenced this pull request Sep 29, 2019
@sre-bot @nolouch
schedule: fix a thread-safe bug and improve code (#1719) (#1734) (#1751)
830ebf5
@Luffbee Luffbee deleted the cherry-pick-1719-3.0 branch October 15, 2019 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@nolouch nolouch nolouch approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-3.1 The PR needs to cherry pick to release-3.1 branch. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Luffbee @nolouch @sre-bot @rleungx