scheduler: support range for schedulers #1791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rleungx
force-pushed
the
range-scheduler
branch
3 times, most recently
from
565fbc5
to
d5b0f15
Compare
nolouch
reviewed
Oct 11, 2019
rleungx
force-pushed
the
range-scheduler
branch
from
d5b0f15
to
058ba9f
Compare
lhy1024
reviewed
Oct 25, 2019
| @@ -43,6 +45,7 @@ func init() { | |||
| } | |||
| conf.Limit = limit | |||
| } | |||
| conf.Name = shuffleHotRegionName | |||
There was a problem hiding this comment.
does it need ranges just like shuffle_ragion and shuffle_leader?
There was a problem hiding this comment.
I'm not sure if the hot region related schedulers should support the range. /cc @nolouch
rleungx
force-pushed
the
range-scheduler
branch
2 times, most recently
from
96bafaf
to
fdd9aeb
Compare
|
/run-all-tests |
rleungx
force-pushed
the
range-scheduler
branch
2 times, most recently
from
d133e8a
to
6be19ab
Compare
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx
force-pushed
the
range-scheduler
branch
from
6be19ab
to
2172e9e
Compare
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #1791 +/- ##
=========================================
Coverage ? 77.49%
=========================================
Files ? 164
Lines ? 16586
Branches ? 0
=========================================
Hits ? 12854
Misses ? 2717
Partials ? 1015
Continue to review full report at Codecov.
|
lhy1024
reviewed
Nov 4, 2019
Signed-off-by: Ryan Leung <rleungx@gmail.com>
lhy1024
approved these changes
Nov 6, 2019
nolouch
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for 1894 |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Currently, the schedulers don't support the key range. e.g. Given a key range, the scheduler only works in this range. And thus to make the scheduler more flexible, we need to support range for schedulers.
What is changed and how it works?
This PR supports range for schedulers. It should be reviewed after
Check List
Tests
edit: