Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the performance of the HTTP API for getting all regions (#1970) #1986

Merged
merged 2 commits into from
Dec 5, 2019

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Dec 5, 2019

What problem does this PR solve?

cherry-pick #1970 to release-3.0

What is changed and how it works?

Optimize convertToAPIRegions and h.rd.JSON

Check List

Tests

  • Unit test

Related changes

  • Need to be included in the release notes

@rleungx rleungx added this to the v3.0.7 milestone Dec 5, 2019
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-3.0@7a5909e). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-3.0    #1986   +/-   ##
==============================================
  Coverage               ?   69.42%           
==============================================
  Files                  ?      170           
  Lines                  ?    16757           
  Branches               ?        0           
==============================================
  Hits                   ?    11634           
  Misses                 ?     4144           
  Partials               ?      979
Impacted Files Coverage Δ
server/core/region.go 93.47% <100%> (ø)
server/api/router.go 100% <100%> (ø)
server/api/region.go 68.8% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a5909e...c88c9f6. Read the comment docs.

@nolouch
Copy link
Contributor

nolouch commented Dec 5, 2019

/run-all-tests

@nolouch nolouch merged commit e88372a into tikv:release-3.0 Dec 5, 2019
@rleungx rleungx modified the milestones: v3.0.7, v3.0.8 Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants