Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule: fix panic caused by removing tombstone (#2015) #2038

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Dec 18, 2019

What problem does this PR solve?

cherry-pick #2015 to release-3.1 branch

What is changed and how it works?

This PR fixes the panic problem by resetting the attached function when removing the store limit.

Check List

Tests

  • Unit test

Related changes

  • Need to be included in the release notes

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx added this to the v3.0.7 milestone Dec 18, 2019
@codecov-io
Copy link

Codecov Report

Merging #2038 into release-3.0 will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-3.0    #2038      +/-   ##
===============================================
- Coverage        69.44%   69.43%   -0.01%     
===============================================
  Files              170      170              
  Lines            16768    16769       +1     
===============================================
  Hits             11644    11644              
- Misses            4144     4145       +1     
  Partials           980      980
Impacted Files Coverage Δ
server/schedule/operator_controller.go 87.19% <100%> (+0.47%) ⬆️
server/util.go 68.15% <0%> (-4.46%) ⬇️
server/region_syncer/client.go 78.94% <0%> (-3.95%) ⬇️
server/leader.go 77.95% <0%> (-2.45%) ⬇️
server/handler.go 52.11% <0%> (+0.49%) ⬆️
server/schedule/operator.go 87.58% <0%> (+0.64%) ⬆️
server/namespace_cluster.go 85.71% <0%> (+3.89%) ⬆️
server/schedulers/shuffle_hot_region.go 65.38% <0%> (+6.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 175f710...9f8e562. Read the comment docs.

@rleungx
Copy link
Member Author

rleungx commented Dec 18, 2019

/run-all-tests

@rleungx rleungx modified the milestones: v3.0.7, v3.0.8 Dec 18, 2019
@disksing disksing merged commit d9c97ed into tikv:release-3.0 Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants