schedule: make region scheduler and checkers aware of placement rules #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Codecov Report
@@ Coverage Diff @@
## master #2051 +/- ##
==========================================
+ Coverage 76.87% 76.87% +<.01%
==========================================
Files 185 185
Lines 18835 18871 +36
==========================================
+ Hits 14479 14507 +28
+ Misses 3253 3250 -3
- Partials 1103 1114 +11
Continue to review full report at Codecov.
|
rleungx
reviewed
Dec 25, 2019
server/cluster/cluster.go
Outdated
| @@ -200,6 +200,13 @@ func (c *RaftCluster) Start(s Server) error { | |||
| return nil | |||
| } | |||
|
|
|||
| defaultReplicas := c.opt.GetMaxReplicas() | |||
| defaultLocationLabels := c.opt.GetLocationLabels() | |||
| c.ruleManager, err = placement.NewRuleManager(c.storage, defaultReplicas, defaultLocationLabels) | |||
There was a problem hiding this comment.
When we disable the placement rules, will it affect the start process?
There was a problem hiding this comment.
It is always loaded no matter enabled or not
server/schedulers/balance_test.go
Outdated
| } | ||
|
|
||
| func (s *testBalanceRegionSchedulerSuite) checkReplacePendingRegion(c *C, tc *mockcluster.Cluster, opt *mockoption.ScheduleOptions, sb schedule.Scheduler) { | ||
|
|
Signed-off-by: disksing <i@disksing.com>
9 tasks
Signed-off-by: disksing <i@disksing.com>
|
Please take a look @rleungx |
Signed-off-by: disksing <i@disksing.com>
lhy1024
approved these changes
Dec 26, 2019
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@disksing merge failed. |
|
/merge |
|
/run-all-tests |
|
@disksing merge failed. |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Continue merge placement rules.
What is changed and how it works?
Check List
Tests