Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: use leader lease to determine tso service validity #1676 #2117

Merged
merged 3 commits into from
Feb 14, 2020

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Feb 11, 2020

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

pick #1676

What is changed and how it works?

cherry-pick

Check List

Tests

  • Integration test

Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch added this to the v3.0.10 milestone Feb 11, 2020
@nolouch
Copy link
Contributor Author

nolouch commented Feb 12, 2020

/run-all-tests

@nolouch
Copy link
Contributor Author

nolouch commented Feb 14, 2020

/run-all-tests

@AndreMouche
Copy link
Member

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 14, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Feb 14, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Feb 14, 2020

@nolouch merge failed.

@nolouch
Copy link
Contributor Author

nolouch commented Feb 14, 2020

/rebuild

@AndreMouche
Copy link
Member

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Feb 14, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Feb 14, 2020

@nolouch merge failed.

@nolouch
Copy link
Contributor Author

nolouch commented Feb 14, 2020

/run-all-tests

Signed-off-by: nolouch <nolouch@gmail.com>
@codecov-io
Copy link

codecov-io commented Feb 14, 2020

Codecov Report

Merging #2117 into release-3.0 will decrease coverage by 0.05%.
The diff coverage is 84.04%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-3.0    #2117      +/-   ##
===============================================
- Coverage        69.69%   69.64%   -0.06%     
===============================================
  Files              170      171       +1     
  Lines            16825    16889      +64     
===============================================
+ Hits             11727    11763      +36     
- Misses            4131     4154      +23     
- Partials           967      972       +5
Impacted Files Coverage Δ
server/server.go 81.19% <ø> (ø) ⬆️
server/grpc_service.go 58.38% <0%> (-0.47%) ⬇️
server/tso.go 79.38% <50%> (+2.78%) ⬆️
server/leader.go 77.91% <81.81%> (-2.9%) ⬇️
server/lease.go 92.18% <92.18%> (ø)
pkg/testutil/operator_check.go 83.33% <0%> (-16.67%) ⬇️
client/client.go 71.81% <0%> (-3.14%) ⬇️
server/schedule/operator.go 86.93% <0%> (-0.65%) ⬇️
server/cluster.go 81.72% <0%> (-0.51%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cf2711...1c9460c. Read the comment docs.

@nolouch
Copy link
Contributor Author

nolouch commented Feb 14, 2020

/run-all-tests

Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch
Copy link
Contributor Author

nolouch commented Feb 14, 2020

/run-all-tests

@nolouch nolouch merged commit 1b67bbb into tikv:release-3.0 Feb 14, 2020
@nolouch nolouch deleted the pick-tso-validity-3.0 branch February 14, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants