Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: fix the encoded path of region key #2399

Merged
merged 2 commits into from
May 8, 2020

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented May 7, 2020

What problem does this PR solve?

Fix the 404 problem when using region key in pd-ctl, which is mentioned in #2351.

What is changed and how it works?

This PR uses UseEncodedPath to solve the %2F problem.

Release note

Fix the 404 problem when using region key in pd-ctl

Check List

Tests

  • Unit test

@rleungx rleungx added the component/api HTTP API. label May 7, 2020
@rleungx rleungx added this to the v4.0.0-ga milestone May 7, 2020
@rleungx rleungx requested review from nolouch and HunDunDM May 7, 2020 05:28
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@nolouch nolouch added the type/bugfix This PR fixes a bug. label May 7, 2020
Copy link
Member

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rleungx
Copy link
Member Author

rleungx commented May 7, 2020

/run-all-tests

@nolouch
Copy link
Contributor

nolouch commented May 8, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 8, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 8, 2020

/run-all-tests

@sre-bot sre-bot merged commit 829afb2 into tikv:master May 8, 2020
@nolouch nolouch added needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch. needs-cherry-pick-release-3.1 The PR needs to cherry pick to release-3.1 branch. labels Jun 24, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 failed

@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #2575

rleungx added a commit to rleungx/pd that referenced this pull request Jun 24, 2020
Signed-off-by: Ryan Leung <rleungx@gmail.com>
ti-srebot added a commit that referenced this pull request Jun 24, 2020
Signed-off-by: Ryan Leung <rleungx@gmail.com>
ti-srebot pushed a commit that referenced this pull request Jun 28, 2020
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/api HTTP API. needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch. needs-cherry-pick-release-3.1 The PR needs to cherry pick to release-3.1 branch. status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants