Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdctl: fix remove evict/grant leader scheduler (#2441) #2446

Merged
merged 2 commits into from
May 25, 2020
Merged

pdctl: fix remove evict/grant leader scheduler (#2441) #2446

merged 2 commits into from
May 25, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 22, 2020

cherry-pick #2441 to release-4.0

What problem does this PR solve?

Fix #2439
Fix #2440

What is changed and how it works?

This PR mainly does the following things:

  • remove component subcommand and some unused code
  • remove redirectDeleteConfigToRemoveScheduler logic

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Fix the issue that receiving 404 error when removing evict/grant leader scheduler in pd-ctl
  • Fix the issue that component subcommand is not removed in pd-ctl

@rleungx @sre-bot
fix remove evict/grant leader scheduler
c41fade 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@sre-bot sre-bot mentioned this pull request May 22, 2020
Merged
@sre-bot sre-bot added component/pd-ctl type/bug The issue is confirmed as a bug. labels May 22, 2020
@sre-bot sre-bot added this to the v4.0.0-rc.2 milestone May 22, 2020
@nolouch nolouch modified the milestones: v4.0.0-rc.2, v4.0.0-ga May 22, 2020
@jebter
Copy link
Collaborator

jebter commented May 25, 2020

/run-all-tests

@lhy1024
Copy link
Contributor

lhy1024 commented May 25, 2020

/approve

@sre-bot
Copy link
Contributor Author

sre-bot commented May 25, 2020

Approve failed.

@jebter
Copy link
Collaborator

jebter commented May 25, 2020

/approve

@sre-bot
Copy link
Contributor Author

sre-bot commented May 25, 2020

Approve failed.

@CLAassistant
Copy link

CLAassistant commented May 25, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jebter
Copy link
Collaborator

jebter commented May 25, 2020

/run-all-tests

@jebter
Copy link
Collaborator

jebter commented May 25, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 25, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented May 25, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented May 25, 2020

@sre-bot merge failed.

@jebter
Copy link
Collaborator

jebter commented May 25, 2020

/run-test

@jebter
Copy link
Collaborator

jebter commented May 25, 2020

/run-all-tests

@jebter jebter merged commit fb80d48 into tikv:release-4.0 May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

@jebter jebter jebter approved these changes

Assignees

@rleungx rleungx

Labels
status/can-merge Indicates a PR has been approved by a committer. type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
v4.0.0-ga
Development

Successfully merging this pull request may close these issues.
6 participants
@sre-bot @jebter @lhy1024 @CLAassistant @nolouch @rleungx