Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule: fix the zero store limit #2564

Merged
merged 5 commits into from
Jun 22, 2020
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jun 20, 2020

What problem does this PR solve?

Fix #2566.

What is changed and how it works?

This PR will init a default store limit config for stores when upgrading from the previous version.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Fix the issue that PD may panic when upgrading from the previous version

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@lhy1024 lhy1024 added component/schedule Scheduling logic. type/bugfix This PR fixes a bug. labels Jun 20, 2020
@rleungx rleungx added the needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. label Jun 22, 2020
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Copy link
Member

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rleungx
Copy link
Member Author

rleungx commented Jun 22, 2020

/run-all-tests

@nolouch
Copy link
Contributor

nolouch commented Jun 22, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 22, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@rleungx merge failed.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
Copy link
Member Author

rleungx commented Jun 22, 2020

/run-all-tests

@rleungx
Copy link
Member Author

rleungx commented Jun 22, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@rleungx merge failed.

@rleungx
Copy link
Member Author

rleungx commented Jun 22, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 68a9215 into tikv:master Jun 22, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #2570

ti-srebot added a commit that referenced this pull request Jun 23, 2020
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/schedule Scheduling logic. needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when upgrading PD to the latest master
5 participants