-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: improve scheduler config reload behavior (#2592) #2608
config: improve scheduler config reload behavior (#2592) #2608
Conversation
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Codecov Report
@@ Coverage Diff @@
## release-4.0 #2608 +/- ##
===============================================
- Coverage 77.09% 77.01% -0.08%
===============================================
Files 205 205
Lines 22138 22119 -19
===============================================
- Hits 17068 17036 -32
- Misses 3765 3779 +14
+ Partials 1305 1304 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
cherry-pick #2592 to release-4.0
Signed-off-by: disksing i@disksing.com
What problem does this PR solve?
Stale scheduler may appear after PD leader change, caused by the reload behavior that it merges in-memory config with persist config.
What is changed and how it works?
Drop in-memory state and merge default schedulers with persist configuration.
Check List
Tests
Release note