Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logutil, *: implement log desensitization (#3011) #3266

Merged
merged 4 commits into from
Dec 31, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #3011 to release-4.0


What problem does this PR solve?

close #2852

Implement log desensitization to omit the region key information from the log.

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has configuration change

Related changes

Release note

  • Support configuration enable-redact-log to enable log desensitization or not.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

@Yisaer you're already a collaborator in bot's repo.

@Yisaer Yisaer modified the milestones: v4.0.9, v4.0.10 Dec 11, 2020
@HunDunDM
Copy link
Member

please fix the conflict

@nolouch
Copy link
Contributor

nolouch commented Dec 24, 2020

cc @Yisaer

Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
@codecov
Copy link

codecov bot commented Dec 31, 2020

Codecov Report

Merging #3266 (c5889a9) into release-4.0 (c3874d9) will decrease coverage by 0.41%.
The diff coverage is 64.44%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #3266      +/-   ##
===============================================
- Coverage        75.20%   74.79%   -0.42%     
===============================================
  Files              209      209              
  Lines            19599    19628      +29     
===============================================
- Hits             14740    14681      -59     
- Misses            3534     3628      +94     
+ Partials          1325     1319       -6     
Flag Coverage Δ
unittests 74.79% <64.44%> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/replication/replication_mode.go 69.66% <33.33%> (-0.87%) ⬇️
server/core/region_tree.go 91.34% <40.00%> (-0.89%) ⬇️
server/cluster/cluster.go 79.95% <50.00%> (-2.50%) ⬇️
server/cluster/cluster_worker.go 69.36% <50.00%> (-2.60%) ⬇️
pkg/logutil/log.go 83.96% <81.25%> (-0.38%) ⬇️
server/config/config.go 74.54% <100.00%> (+0.17%) ⬆️
server/schedule/checker/merge_checker.go 70.00% <100.00%> (+0.76%) ⬆️
server/statistics/store_collection.go 58.53% <0.00%> (-34.96%) ⬇️
server/region_syncer/server.go 79.38% <0.00%> (-9.93%) ⬇️
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3874d9...c5889a9. Read the comment docs.

@Yisaer
Copy link
Contributor

Yisaer commented Dec 31, 2020

/merge

@ti-chi-bot
Copy link
Member

@Yisaer: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1204d76

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 31, 2020
@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR has out-of-dated and I have automatically updated it for you.
At the same time I will also trigger all tests for you:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/log Log. component/security Security logic. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants