Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: let tso processing time not include consumption on the network (#3523) #3524

Merged
merged 2 commits into from
May 8, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 25, 2021

cherry-pick #3523 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In pd repo:
git pr https://github.com/tikv/pd/pull/3524

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/pd.git pr/3524:release-4.0-c4f22fd42119

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

Sometimes we see the handle tso duration is high in the PD side, which usually caused by the network.
image

What is changed and how it works?

Check List

Tests

  • Unit test

Release note

  • metrics: let tso processing time not include consumption on the network

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-srebot
Copy link
Contributor Author

@nolouch please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/pd/invitations

@nolouch nolouch modified the milestones: v4.0.12, v4.0.13 Mar 25, 2021
@nolouch
Copy link
Contributor

nolouch commented Apr 7, 2021

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1e22f01

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2021
@sonarcloud
Copy link

sonarcloud bot commented Apr 7, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

No Coverage information No Coverage information
2.9% 2.9% Duplication

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #3524 (0831103) into release-4.0 (05b9d6d) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #3524      +/-   ##
===============================================
+ Coverage        74.74%   74.77%   +0.03%     
===============================================
  Files              210      210              
  Lines            19826    19826              
===============================================
+ Hits             14818    14824       +6     
+ Misses            3669     3664       -5     
+ Partials          1339     1338       -1     
Flag Coverage Δ
unittests 74.77% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/grpc_service.go 59.47% <100.00%> (ø)
server/heartbeat_streams.go 65.93% <0.00%> (-6.60%) ⬇️
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
server/schedulers/random_merge.go 60.65% <0.00%> (-3.28%) ⬇️
server/server.go 73.34% <0.00%> (-0.50%) ⬇️
server/handler.go 44.50% <0.00%> (+0.50%) ⬆️
server/tso/tso.go 81.88% <0.00%> (+0.72%) ⬆️
server/member/leader.go 68.80% <0.00%> (+2.75%) ⬆️
pkg/etcdutil/etcdutil.go 80.88% <0.00%> (+2.94%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05b9d6d...0831103. Read the comment docs.

@rleungx rleungx added type/cherry-pick-for-release-4.0 The PR belongs to release-4.0 cherry pick. and removed type/cherry-pick-for-release-1.0 labels Apr 25, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label May 8, 2021
@zhouqiang-cl
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@zhouqiang-cl: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit d87a805 into tikv:release-4.0 May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-4.0 The PR belongs to release-4.0 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants