-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: let tso processing time not include consumption on the network (#3523) #3524
metrics: let tso processing time not include consumption on the network (#3523) #3524
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
@nolouch please accept the invitation then you can push to the cherry-pick pull requests. |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 1e22f01
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #3524 +/- ##
===============================================
+ Coverage 74.74% 74.77% +0.03%
===============================================
Files 210 210
Lines 19826 19826
===============================================
+ Hits 14818 14824 +6
+ Misses 3669 3664 -5
+ Partials 1339 1338 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
@zhouqiang-cl: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #3523 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In pd repo: git pr https://github.com/tikv/pd/pull/3524
After apply modifications, you can push your change to this PR via:
Signed-off-by: nolouch nolouch@gmail.com
What problem does this PR solve?
Sometimes we see the handle tso duration is high in the PD side, which usually caused by the network.
What is changed and how it works?
Check List
Tests
Release note