Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross compile failed due to sqlite in PD. #729

Closed
Yisaer opened this issue Aug 7, 2020 · 2 comments
Closed

Cross compile failed due to sqlite in PD. #729

Yisaer opened this issue Aug 7, 2020 · 2 comments

Comments

@Yisaer
Copy link
Contributor

Yisaer commented Aug 7, 2020

Bug Report

Please answer these questions before submitting your issue. Thanks!
PD crossing compile failed due to sqlite on macOS. Here 's the log:

$ SWAGGER=0 GOOS=linux make pd-server
make dashboard-ui
./scripts/embed-dashboard-ui.sh
+ Create cache directory
+ Fetch Dashboard Go module
+ Discover Dashboard UI version
  - Dashboard directory: /Users/yisa/Downloads/Github/GoProject/pkg/mod/github.com/hundundm/tidb-dashboard@v0.0.0-20200707082626-f4a10d7b1fab
  - Dashboard ui version: 20200619_3
+ Check embedded assets exists in cache
  - Cached archive exists: /Users/yisa/Downloads/Github/GoProject/src/github.com/pingcap/pd/.dashboard_asset_cache/embedded-assets-golang-20200619_3.zip
+ Unpack embedded asset from archive
Archive:  /Users/yisa/Downloads/Github/GoProject/src/github.com/pingcap/pd/.dashboard_asset_cache/embedded-assets-golang-20200619_3.zip
  inflating: embedded_assets_handler.go  
  - Unpacked pkg/dashboard/uiserver/embedded_assets_handler.go
CGO_ENABLED=1 go build  -gcflags '' -ldflags '-X "github.com/pingcap/pd/v4/server.PDReleaseVersion=v4.0.0-rc.2-77-g2a5e97ac" -X "github.com/pingcap/pd/v4/server.PDBuildTS=2020-08-07 05:42:42" -X "github.com/pingcap/pd/v4/server.PDGitHash=2a5e97ac3d7e9ea1e3c89d04a741e19ee9acb885" -X "github.com/pingcap/pd/v4/server.PDGitBranch=sh-poc" -X "github.com/pingcap/pd/v4/server.PDEdition=Community"' -tags "" -o bin/pd-server cmd/pd-server/main.go
# os/user
../../../../../../GOVERSION/go1.13.4/src/os/user/getgrouplist_unix.go:16:35: warning: passing 'gid_t *' (aka 'unsigned int *') to parameter of type 'int *' converts between pointers to integer types with different sign [-Wpointer-sign]
/Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/unistd.h:653:43: note: passing argument to parameter here
# github.com/mattn/go-sqlite3
sqlite3-binding.c:33123:42: error: use of undeclared identifier 'pread64'
sqlite3-binding.c:33141:42: error: use of undeclared identifier 'pwrite64'
sqlite3-binding.c:33274:22: error: invalid application of 'sizeof' to an incomplete type 'struct unix_syscall []'
sqlite3-binding.c:33283:22: error: invalid application of 'sizeof' to an incomplete type 'struct unix_syscall []'
sqlite3-binding.c:33310:20: error: invalid application of 'sizeof' to an incomplete type 'struct unix_syscall []'
sqlite3-binding.c:33327:16: error: invalid application of 'sizeof' to an incomplete type 'struct unix_syscall []'
sqlite3-binding.c:14220:38: note: expanded from macro 'ArraySize'
sqlite3-binding.c:33331:14: error: invalid application of 'sizeof' to an incomplete type 'struct unix_syscall []'
sqlite3-binding.c:14220:38: note: expanded from macro 'ArraySize'
sqlite3-binding.c:35984:11: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
sqlite3-binding.c:33127:49: note: expanded from macro 'osPread64'
sqlite3-binding.c:36096:17: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
sqlite3-binding.c:33145:57: note: expanded from macro 'osPwrite64'
make: *** [pd-server] Error 2

What did you do?
sqlite won't block PD cross compile process.

What did you expect to see?

What did you see instead?

What version of TiDB Dashboard are you using (./tidb-dashboard --version)?

@Yisaer Yisaer added the type/bug label Aug 7, 2020
@kennytm
Copy link
Contributor

kennytm commented Aug 7, 2020

The error is caused by the go-sqlite3 dependency. mattn/go-sqlite3#560 seems relevant.

@stale
Copy link

stale bot commented Oct 6, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the type/stale label Oct 6, 2020
@Yisaer Yisaer closed this as completed Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants