Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

Use GC-TTL to keep the GC Lifetime #389

Closed
kennytm opened this issue Sep 4, 2020 · 1 comment · Fixed by #396
Closed

Use GC-TTL to keep the GC Lifetime #389

kennytm opened this issue Sep 4, 2020 · 1 comment · Fixed by #396
Labels
difficulty/2-medium Medium-difficulty issue feature-request This issue is a feature request priority/P1 High priority issue, must be solved before next release
Milestone

Comments

@kennytm
Copy link
Collaborator

kennytm commented Sep 4, 2020

Feature Request

Is your feature request related to a problem? Please describe:

Currently we use UPDATE mysql.tidb SET VARIABLE_VALUE = '100h' WHERE VARIABLE_NAME = 'tikv_gc_life_time' to disable the GC. This is error-prone when Lightning exits before this can be reverted.

Describe the feature you'd like:

Use the more recent GC-TTL API so that PD can automatically re-enable GC even when Lightning exits accidentally.

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Optimization:

@kennytm kennytm added the feature-request This issue is a feature request label Sep 4, 2020
@kennytm kennytm added difficulty/2-medium Medium-difficulty issue priority/P1 High priority issue, must be solved before next release labels Sep 4, 2020
@kennytm kennytm added this to the v4.0.6 milestone Sep 4, 2020
@kennytm
Copy link
Collaborator Author

kennytm commented Sep 4, 2020

Note: GC-TTL should only be used when the target cluster is 4.0.0+. On 3.x, keep using the old method.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
difficulty/2-medium Medium-difficulty issue feature-request This issue is a feature request priority/P1 High priority issue, must be solved before next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant