Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cert-manager for certificate management #1669

Closed
tennix opened this issue Feb 10, 2020 · 4 comments
Closed

Support cert-manager for certificate management #1669

tennix opened this issue Feb 10, 2020 · 4 comments
Assignees
Labels
area/controller area/webhook Related to webhook enhancement New feature or request priority:P1
Milestone

Comments

@tennix
Copy link
Member

tennix commented Feb 10, 2020

Feature Request

Is your feature request related to a problem? Please describe:

Currently, the TiDB cluster TLS certificate is managed by tidb-operator using k8s built-in certificate generation. It does not support certificate renewal, it's better to use cert-manager to manage the certificates. Also it supports other kinds of certificate provider like letsencrypt.

Describe the feature you'd like:

Integrate cert-manager for certificate management.

@tennix tennix added the enhancement New feature or request label Feb 10, 2020
@Yisaer Yisaer added area/controller area/webhook Related to webhook labels Feb 10, 2020
@gregwebs
Copy link
Contributor

cert-manager may be the default in the K8s world now.
However, we should also try to see how a user could use SPIFFE. This is a standard that is meant to provide a framework for automatic cert provisioning. It works without k8s, but works with it as well.

@Smana
Copy link
Contributor

Smana commented Feb 27, 2020

Regarding cert-manager we just need to be able to define the secret created by cert-manager and just support the expected file names: tls.key, tls.crt, ca.crt

That would be a very good first step, then I don't know how would be handle the renewal ? How is it handled right now by the way ?

@tennix
Copy link
Member Author

tennix commented Feb 27, 2020

@Smana cert-manager support certificate renewal. And TiDB components will support re-read certificate files every time a new connection is established. So the service will not be interrupted during certificate renewal.

@DanielZhangQD DanielZhangQD added this to the v1.1.0 milestone Mar 9, 2020
@weekface
Copy link
Contributor

tidb-operator support any certificate CA includes cert-manager: #1855

Certificate renew alse verified. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller area/webhook Related to webhook enhancement New feature or request priority:P1
Projects
None yet
Development

No branches or pull requests

6 participants