Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_lock() and release_lock() should produce errors #10929

Closed
morgo opened this issue Jun 25, 2019 · 0 comments · Fixed by #10987
Closed

get_lock() and release_lock() should produce errors #10929

morgo opened this issue Jun 25, 2019 · 0 comments · Fixed by #10987
Labels
type/compatibility type/enhancement The issue or PR belongs to an enhancement.

Comments

@morgo
Copy link
Contributor

morgo commented Jun 25, 2019

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?

Get_lock and release_lock were added in #1437 for compatibility with rails. But these functions don't do anything, which could be very dangerous.

  1. What did you expect to see?

In two concurrent sessions:

SELECT get_lock('acdc', 5);
SELECT get_lock('acdc', 5);

Maybe this can be handled similar to #10065 where the default is an error, and then you can 'skip' it?

  1. What did you see instead?

The second session should block waiting for 5 seconds.

  1. What version of TiDB are you using (tidb-server -V or run select tidb_version(); on TiDB)?
mysql> select tidb_version()\G
*************************** 1. row ***************************
tidb_version(): Release Version: v3.0.0-rc.1-218-gc12abec6c
Git Commit Hash: c12abec6cb7b19d9fc8f27ea75277f6913afac4a
Git Branch: master
UTC Build Time: 2019-06-25 01:23:34
GoVersion: go version go1.12.1 linux/amd64
Race Enabled: false
TiKV Min Version: 2.1.0-alpha.1-ff3dd160846b7d1aed9079c389fc188f7f5ea13e
Check Table Before Drop: false
1 row in set (0.01 sec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/compatibility type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants