Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Latency Quantiles (like 99% Query Time) to Statements #17621

Open
breezewish opened this issue Jun 3, 2020 · 1 comment
Open

Add Latency Quantiles (like 99% Query Time) to Statements #17621

breezewish opened this issue Jun 3, 2020 · 1 comment
Labels
component/infoschema epic/slow-query feature/accepted This feature request is accepted by product managers type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@breezewish
Copy link
Member

breezewish commented Jun 3, 2020

Feature Request

Is your feature request related to a problem? Please describe:

Now only avg, max and min latency are displayed, which is usually not enough for real-world scenarios. For example, in grafana, we usually look at 90%, 99% or even 99.9% metrics. This capability is now missing when looking at statements.

Describe the feature you'd like:

Add quantiles to important statement fields:

  • LATENCY
  • COP_PROCESS_TIME
  • COP_WAIT_TIME
  • TOTAL_KEYS
  • PROCESSED_KEYS
  • WRITE_KEYS
  • PREWRITE_TIME
  • COMMIT_TIME

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

This feature can be implemented by adding buckets (like Prometheus) to the different latency fields and then use algorithms same to Prometheus to aggregate these buckets to get a specific quantile latency as demand.

@wwar
Copy link

wwar commented Jun 4, 2020

See also: #15349

@zz-jason zz-jason removed their assignment Jul 23, 2020
@zz-jason zz-jason added the feature/accepted This feature request is accepted by product managers label Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/infoschema epic/slow-query feature/accepted This feature request is accepted by product managers type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

5 participants