Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeNewDecimal handle wrong about string value. #22394

Closed
erwadba opened this issue Jan 14, 2021 · 2 comments · Fixed by #22407
Closed

TypeNewDecimal handle wrong about string value. #22394

erwadba opened this issue Jan 14, 2021 · 2 comments · Fixed by #22407
Labels
severity/moderate sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@erwadba
Copy link
Contributor

erwadba commented Jan 14, 2021

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

test> drop table t1;
Query OK, 0 rows affected (0.27 sec)
test> create table t1(id decimal(10));
Query OK, 0 rows affected (0.12 sec)
test> insert into t1 values('1dsf');
Query OK, 1 row affected (0.03 sec)
test> 

2. What did you expect to see? (Required)

In Mysql will report err like

mysql> insert into t1 values('1dsf');
ERROR 1366 (HY000): Incorrect decimal value: '1dsf' for column 'id' at row 1
mysql>

3. What did you see instead (Required)

insert success.

4. What is your TiDB version? (Required)

test> select tidb_version()\G
*************************** 1. row ***************************
tidb_version(): Release Version: v4.0.8
Edition: Community
Git Commit Hash: 66ac9fc31f1733e5eb8d11891ec1b38f9c422817
Git Branch: heads/refs/tags/v4.0.8
UTC Build Time: 2020-10-30 08:21:16
GoVersion: go1.13
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.00 sec)
test>
@erwadba erwadba added the type/bug The issue is confirmed as a bug. label Jan 14, 2021
@beihaiguaishou
Copy link
Contributor

/assign

@beihaiguaishou beihaiguaishou removed their assignment Jan 20, 2021
@XuHuaiyu XuHuaiyu added sig/sql-infra SIG: SQL Infra and removed sig/execution SIG execution labels Feb 19, 2021
@jebter jebter added this to the v5.0.0 ga milestone Mar 20, 2021
@zimulala zimulala removed this from the v5.0.0 ga milestone Mar 23, 2021
@github-actions
Copy link

Please check whether the issue should be labeled with 'affects-x.y' or 'fixes-x.y.z', and then remove 'needs-more-info' label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/moderate sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants