Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ddl test suite of stmtflow failed with 1pc enabled #23331

Closed
zyguan opened this issue Mar 16, 2021 · 2 comments · Fixed by #23342
Closed

The ddl test suite of stmtflow failed with 1pc enabled #23331

zyguan opened this issue Mar 16, 2021 · 2 comments · Fixed by #23342
Assignees
Labels
duplicate Issues or pull requests already exists.

Comments

@zyguan
Copy link
Contributor

zyguan commented Mar 16, 2021

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

stmtflow play ddl/add_column/addcolumn_createindex_complex.t.sql  --dsn 'root:@tcp(...)/test'

The stmtflow tool is located at here and the test suite can be found here.

2. What did you expect to see? (Required)

No error reported.

3. What did you see instead (Required)

One of DDL got stuck and the test finally timed out.

2021-03-16_105614

4. What is your TiDB version? (Required)

master (cad8e15)

@zyguan zyguan added type/bug The issue is confirmed as a bug. sig/transaction SIG:Transaction severity/major labels Mar 16, 2021
@cfzjywxk
Copy link
Contributor

There seem to be two problems:

  1. The left pessimistic locks are not cleaned up using 1pc protocol to commit, blocking other concurrent transactions on these keys.
  2. The ttlManager is not closed, if the max ts caculation error is reported using async commit or 1pc, thus the left pessimistic locks could not be resolved by the ddl backfill worker.

@ti-srebot
Copy link
Contributor

Please edit this comment or add a new comment to complete the following information

Not a bug

  1. Remove the 'type/bug' label
  2. Add notes to indicate why it is not a bug

Duplicate bug

  1. Add the 'type/duplicate' label
  2. Add the link to the original bug

Bug

Note: Make Sure that 'component', and 'severity' labels are added
Example for how to fill out the template: #20100

1. Root Cause Analysis (RCA) (optional)

2. Symptom (optional)

3. All Trigger Conditions (optional)

4. Workaround (optional)

5. Affected versions

6. Fixed versions

@cfzjywxk cfzjywxk added duplicate Issues or pull requests already exists. and removed severity/major sig/transaction SIG:Transaction type/bug The issue is confirmed as a bug. labels Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issues or pull requests already exists.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants