Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestClusterTables/ForClusterServerInfo fails on apple M1 #29757

Closed
zhangyangyu opened this issue Nov 14, 2021 · 2 comments · Fixed by #29933
Closed

TestClusterTables/ForClusterServerInfo fails on apple M1 #29757

zhangyangyu opened this issue Nov 14, 2021 · 2 comments · Fixed by #29933
Labels
component/test severity/major type/bug The issue is confirmed as a bug.

Comments

@zhangyangyu
Copy link
Member

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

make test

2. What did you expect to see? (Required)

all cases pass

3. What did you see instead (Required)

--- FAIL: TestClusterTables (2.11s)
    --- FAIL: TestClusterTables/ForClusterServerInfo (1.53s)
        cluster_tables_serial_test.go:154:
                Error Trace:    cluster_tables_serial_test.go:154
                Error:          Not equal:
                                expected: set.StringSet{"cpu":struct {}{}, "disk":struct {}{}, "memory":struct {}{}, "net":struct {}{}}
                                actual  : set.StringSet{"disk":struct {}{}, "memory":struct {}{}, "net":struct {}{}}

                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -1,4 +1,2 @@
                                -(set.StringSet) (len=4) {
                                - (string) (len=3) "cpu": (struct {}) {
                                - },
                                +(set.StringSet) (len=3) {
                                  (string) (len=4) "disk": (struct {}) {
                Test:           TestClusterTables/ForClusterServerInfo
                Messages:       sql: select * from information_schema.CLUSTER_HARDWARE;

4. What is your TiDB version? (Required)

master branch
golang 1.17.2
apple M1

I think the root cause is https://github.com/pingcap/sysutil/blob/e5c5906ed1e736d38565158bc6da9e3f2ee07034/hardware_info.go#L18. This call will fail on apple M1 due to shirou/gopsutil#1000.

@zhangyangyu zhangyangyu added the type/bug The issue is confirmed as a bug. label Nov 14, 2021
@zhangyangyu
Copy link
Member Author

/component test

@github-actions
Copy link

Please check whether the issue should be labeled with 'affects-x.y' or 'fixes-x.y.z', and then remove 'needs-more-info' label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants