New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FOLLOWERS=99 should be illegal #30453

Closed

Tracked by

morgo opened this issue Dec 6, 2021 · 1 comment · Fixed by #30715

Closed

Tracked by

FOLLOWERS=99 should be illegal #30453

morgo opened this issue Dec 6, 2021 · 1 comment · Fixed by #30715

Assignees

Contributor

morgo commented Dec 6, 2021 •

edited

Loading

The following syntax is currently considered legal in TiDB:

CREATE PLACEMENT policy p1 CONSTRAINTS="[+region=us-east-2]" FOLLOWERS=99;
create table t1 (a int) followers=99;

It seems that PD does not validate this either, but I propose the following:

A non even number of followers returns a warning (raft recommends using an even number of followers, so the total group has an odd number).
A number of followers greater than 8 returns an error.

morgo mentioned this issue

Define the placement of data by SQL statements #18030

Closed

Contributor

sylzd commented Dec 7, 2021

/assign

ti-chi-bot assigned sylzd

sylzd mentioned this issue

ddl: handle the incorrect number of placement followers #30715

Merged

12 tasks

ti-chi-bot closed this as completed in #30715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment