Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truly kill a query when it exceeds max excution time even if mysql client gets stuck #39449

Closed
gengliqi opened this issue Nov 29, 2022 · 2 comments
Labels
sig/sql-infra SIG: SQL Infra type/enhancement The issue or PR belongs to an enhancement.

Comments

@gengliqi
Copy link
Contributor

gengliqi commented Nov 29, 2022

Enhancement

In the current implementation, the kill operation will take effect only after calling next function.
However, if a MySQL client doesn't receive data for a long time, the next function wasn't called for a long time either.
This case can lead to many resources(i.e. goroutine, memory) can not be released.
Also, many logs like below will be outputted each 100ms, which is very annoying.
image

In order to improve robustness, we need to change the kill process to release resources as many as possible.

@gengliqi gengliqi added the type/enhancement The issue or PR belongs to an enhancement. label Nov 29, 2022
@LittleFall LittleFall added the sig/sql-infra SIG: SQL Infra label Nov 29, 2022
@pingcap pingcap deleted a comment from ti-chi-bot Aug 17, 2023
@pingcap pingcap deleted a comment from ti-chi-bot bot Aug 17, 2023
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Aug 17, 2023

Can we close it since #44675 was solved?

@gengliqi
Copy link
Contributor Author

close due to #52882

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

3 participants